koordinator
koordinator copied to clipboard
manager: add featuregate to remove the restriction of parent quota submit pods
Ⅰ. Describe what this PR does
This pr add a featureGate for users to remove the restriction of parent quota submit pods.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in
make test
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.51%. Comparing base (
19de595
) to head (23eb93d
). Report is 21 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1929 +/- ##
==========================================
- Coverage 67.53% 67.51% -0.03%
==========================================
Files 414 416 +2
Lines 46287 46400 +113
==========================================
+ Hits 31260 31326 +66
- Misses 12756 12790 +34
- Partials 2271 2284 +13
Flag | Coverage Δ | |
---|---|---|
unittests | 67.51% <100.00%> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
The webhook part looks fine to me. The calculation process of the runtime needs to deduct the usage of the parent node, and issues will be recorded for tracking. /lgtm
#1946
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hormes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/features/OWNERS~~ [hormes]
- ~~pkg/webhook/OWNERS~~ [hormes]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment