koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

proposal: support pod customizing numa policy

Open KunWuLuan opened this issue 1 year ago • 6 comments

Ⅰ. Describe what this PR does

Introduce new api for pod level numa topology policy. With the new api, users can specify numa topology policy for each pod, so that pods that are more sensitive to latency can decide how they need to be orchestrated, rather than being passively scheduled according to the numa topology policy on the node.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

KunWuLuan avatar Feb 21 '24 11:02 KunWuLuan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.47%. Comparing base (da6a05c) to head (23f7ce6). Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
+ Coverage   67.23%   67.47%   +0.24%     
==========================================
  Files         407      420      +13     
  Lines       45644    46858    +1214     
==========================================
+ Hits        30687    31617     +930     
- Misses      12741    12938     +197     
- Partials     2216     2303      +87     
Flag Coverage Δ
unittests 67.47% <ø> (+0.24%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 21 '24 11:02 codecov[bot]

BTW, please fix DCO by git commit -s.

hormes avatar Feb 28 '24 02:02 hormes

/lgtm

hormes avatar Mar 05 '24 07:03 hormes

/lgtm

eahydra avatar Mar 06 '24 09:03 eahydra

@hormes Hi, is there any questions for this proposal? If not we can start to implement the new feature. Please take a look if you have time, thanks.

KunWuLuan avatar Mar 07 '24 07:03 KunWuLuan

@hormes Hi, is there any questions for this proposal? If not we can start to implement the new feature. Please take a look if you have time, thanks.

LGTM. /approve

hormes avatar Mar 12 '24 06:03 hormes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Mar 12 '24 06:03 koordinator-bot[bot]