koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

proposal: add metric prediction framework

Open xueche opened this issue 1 year ago • 2 comments

Ⅰ. Describe what this PR does

add resource recommend proposal

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

xueche avatar Jan 30 '24 10:01 xueche

Codecov Report

Attention: Patch coverage is 67.75087% with 466 lines in your changes are missing coverage. Please review.

Project coverage is 67.53%. Comparing base (ad36a0b) to head (c4d7644). Report is 51 commits behind head on main.

:exclamation: Current head c4d7644 differs from pull request most recent head cedff54. Consider uploading reports for the commit cedff54 to get more accurate results

Files Patch % Lines
...koordlet/runtimehooks/hooks/terwayqos/terwayqos.go 40.89% 160 Missing and 12 partials :warning:
...bhook/cm/plugins/sloconfig/resource_qos_checker.go 68.58% 33 Missing and 16 partials :warning:
pkg/scheduler/frameworkext/reservation_info.go 56.92% 22 Missing and 6 partials :warning:
pkg/koordlet/util/perf_group/perf_group_linux.go 62.71% 16 Missing and 6 partials :warning:
pkg/scheduler/plugins/nodenumaresource/plugin.go 74.07% 13 Missing and 8 partials :warning:
pkg/scheduler/plugins/reservation/transformer.go 48.38% 11 Missing and 5 partials :warning:
pkg/koordlet/statesinformer/impl/kubelet_stub.go 63.15% 10 Missing and 4 partials :warning:
...kg/scheduler/plugins/elasticquota/plugin_helper.go 42.85% 9 Missing and 3 partials :warning:
pkg/webhook/pod/validating/verify_annotations.go 69.44% 10 Missing and 1 partial :warning:
...ordlet/qosmanager/plugins/blkio/blkio_reconcile.go 81.81% 9 Missing and 1 partial :warning:
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
+ Coverage   67.27%   67.53%   +0.25%     
==========================================
  Files         411      420       +9     
  Lines       45875    47059    +1184     
==========================================
+ Hits        30863    31781     +918     
- Misses      12775    12971     +196     
- Partials     2237     2307      +70     
Flag Coverage Δ
unittests 67.53% <67.75%> (+0.25%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 10:01 codecov[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Mar 27 '24 03:03 koordinator-bot[bot]