koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

feat: add priority in ClusterColocationProfile

Open j4ckstraw opened this issue 1 year ago • 2 comments

Ⅰ. Describe what this PR does

  • make ClusterColocationProfile support priorty
  • add a annotation to skip next profiles.

Maybe you want to only match once, and have priority when you have many clusterColocationProfiles matched, this patch implement it.

Ⅱ. Does this pull request fix one issue?

https://github.com/koordinator-sh/koordinator/issues/1871

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [x] All checks passed in make test

j4ckstraw avatar Jan 29 '24 06:01 j4ckstraw

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign eahydra, fillzpp after the PR has been reviewed. You can assign the PR to them by writing /assign @eahydra @fillzpp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Jan 29 '24 06:01 koordinator-bot[bot]

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 67.29%. Comparing base (22ffeec) to head (9864118). Report is 88 commits behind head on main.

Files Patch % Lines
...webhook/pod/mutating/cluster_colocation_profile.go 10.00% 7 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
+ Coverage   67.27%   67.29%   +0.02%     
==========================================
  Files         411      411              
  Lines       45848    45885      +37     
==========================================
+ Hits        30842    30880      +38     
+ Misses      12774    12764      -10     
- Partials     2232     2241       +9     
Flag Coverage Δ
unittests 67.29% <10.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 29 '24 10:01 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close Thank you for your contributions.

stale[bot] avatar May 01 '24 00:05 stale[bot]

This issue has been automatically closed because it has not had recent activity. This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed You can:
  • Reopen this PR with /reopen Thank you for your contributions.

stale[bot] avatar May 31 '24 03:05 stale[bot]