koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

proposal: add enhance mid-tier resource proposal

Open j4ckstraw opened this issue 1 year ago • 6 comments

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in make test

j4ckstraw avatar Nov 28 '23 06:11 j4ckstraw

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign hormes after the PR has been reviewed. You can assign the PR to them by writing /assign @hormes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Nov 28 '23 06:11 koordinator-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3784df1) 66.11% compared to head (cb3cf33) 66.11%. Report is 11 commits behind head on main.

:exclamation: Current head cb3cf33 differs from pull request most recent head e6b42c9. Consider uploading reports for the commit e6b42c9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1762    +/-   ##
========================================
  Coverage   66.11%   66.11%            
========================================
  Files         388      390     +2     
  Lines       42425    42589   +164     
========================================
+ Hits        28048    28159   +111     
- Misses      12305    12346    +41     
- Partials     2072     2084    +12     
Flag Coverage Δ
unittests 66.11% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 28 '23 06:11 codecov[bot]

I have one more question: How does the scheduler's LoadAware Scheduling plugin support middle tiers?

I need to think about it.

j4ckstraw avatar Dec 01 '23 02:12 j4ckstraw

/milestone 1.5

ZiMengSheng avatar Jan 02 '24 11:01 ZiMengSheng

@ZiMengSheng: The provided milestone is not valid for this repository. Milestones in this repository: [someday, v1.4, v1.5]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

koordinator-bot[bot] avatar Jan 02 '24 11:01 koordinator-bot[bot]

/milestone v1.5

ZiMengSheng avatar Jan 02 '24 11:01 ZiMengSheng