koordinator icon indicating copy to clipboard operation
koordinator copied to clipboard

feat: add unallocated resource into mid resource

Open j4ckstraw opened this issue 1 year ago • 7 comments

implement mid-tier overcommitment in https://koordinator.sh/docs/designs/node-prediction/#mid-tier-overcommitment

Allocatable[Mid]' := min(Reclaimable[Mid], NodeAllocatable * thresholdRatio) + Unallocated[Mid] Unallocated[Mid] = max(NodeAllocatable - Allocated[Prod], 0)

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • [x] I have written necessary docs and comments
  • [x] I have added necessary unit tests and integration tests
  • [x] All checks passed in make test

j4ckstraw avatar Nov 22 '23 07:11 j4ckstraw

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign zwzhang0107 after the PR has been reviewed. You can assign the PR to them by writing /assign @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

koordinator-bot[bot] avatar Nov 22 '23 07:11 koordinator-bot[bot]

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.16%. Comparing base (3784df1) to head (ff65d69). Report is 231 commits behind head on main.

Files Patch % Lines
...troller/noderesource/plugins/midresource/plugin.go 86.48% 4 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
+ Coverage   66.11%   66.16%   +0.04%     
==========================================
  Files         388      388              
  Lines       42425    42457      +32     
==========================================
+ Hits        28048    28090      +42     
+ Misses      12305    12298       -7     
+ Partials     2072     2069       -3     
Flag Coverage Δ
unittests 66.16% <86.48%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 22 '23 10:11 codecov[bot]

maybe Allocatable[Mid]' := min(Reclaimable[Mid] + Unallocated[Mid], NodeAllocatable * thresholdRatio) is better than Allocatable[Mid]' := min(Reclaimable[Mid], NodeAllocatable * thresholdRatio) + Unallocated[Mid]

j4ckstraw avatar Nov 23 '23 01:11 j4ckstraw

#1762

j4ckstraw avatar Nov 28 '23 09:11 j4ckstraw

This issue has been automatically marked as stale because it has not had recent activity. This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close Thank you for your contributions.

stale[bot] avatar Feb 26 '24 21:02 stale[bot]

/remove-lifecycle stale

j4ckstraw avatar Mar 22 '24 06:03 j4ckstraw

This issue has been automatically marked as stale because it has not had recent activity. This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed You can:
  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close Thank you for your contributions.

stale[bot] avatar Jun 20 '24 21:06 stale[bot]

This issue has been automatically closed because it has not had recent activity. This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed You can:
  • Reopen this PR with /reopen Thank you for your contributions.

stale[bot] avatar Jul 20 '24 22:07 stale[bot]

/reopen

j4ckstraw avatar Jul 31 '24 03:07 j4ckstraw

@j4ckstraw: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

koordinator-bot[bot] avatar Jul 31 '24 03:07 koordinator-bot[bot]

/close

j4ckstraw avatar Aug 05 '24 02:08 j4ckstraw

@j4ckstraw: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

koordinator-bot[bot] avatar Aug 05 '24 02:08 koordinator-bot[bot]