kart icon indicating copy to clipboard operation
kart copied to clipboard

kart status doesn't differentiate between updates and conflicts

Open olsen232 opened this issue 6 months ago • 0 comments

Originally, there were three types of change in a diff:

  • inserts
  • updates
  • deletes

However, as Kart gets more complex, it is possible for the user to put various changes into the working copy that may be uncommittable for various reasons. These are displayed as such in kart diff but not always summarised in kart status:

  • [x] spatial filter conflict - user has tried to do an "insert", probably, but they've inadvertently reused a primary key value that was already in use outside the current spatial filter. so, this is actually an update, but we count it as a spatial filter conflict and don't let the user commit it unless they provide a special flag. kart status reports these correctly.
  • [ ] ListOfConflicts - user has managed to provide more than one conflicting value for a single dataset - for example, adding tiles with different CRSs to a single dataset, such that Kart doesn't know which CRS to commit as the dataset CRS. kart diff shows these as conflicts, but kart status summarises them as inserts or updates.

olsen232 avatar Dec 12 '23 22:12 olsen232