kart-qgis-plugin icon indicating copy to clipboard operation
kart-qgis-plugin copied to clipboard

'show feature history' will always show features from a layer even if it isn't currently visible

Open pfw opened this issue 3 years ago • 2 comments

Describe the bug If there are more than one layers from Kart repos on a map and "Activate 'show feature history' map tool" is selected on a layer which is not the top most feature history from that layer will always be used even if features from other layers are 'in front' of that chosen layer.

Expected behavior Not sure as the choice was explicit but the end result is at best non obvious, particularly if the layers are from the same 'Author'. Potentially it should highlight the selected feature as per 'select features' QGIS command.

Screenshots

Screenshot 2022-11-07 at 6 16 10 pm Screenshot 2022-11-07 at 6 20 25 pm Screenshot 2022-11-07 at 6 23 14 pm

Version info (this is important!):

  • Operating System (e.g. Windows 10, macOS): MacOS
  • QGIS, Kart & Plugin details: QGIS 3.28 Kart plugin 1.0.4
Kart Plugin version
1.0.4
QGIS version
3.28.0-Firenze
Operating system
macOS 13.0 x86_64 i386 64bit
Kart version
Kart v0.11.5, Copyright (c) Kart Contributors
» GDAL v3.4.0; PROJ v6.3.0
» PyGit2 v1.9.0; Libgit2 v1.4.2; Git v2.33.GIT
» SQLAlchemy v1.4.40; pysqlite3 v2.6.0/v3.31.1; SpatiaLite v5.0.1; Libpq v14.0.5
» SpatialIndex v1.9.3

pfw avatar Nov 07 '22 07:11 pfw

Expected behavior

At first thought I'd expect it to only work for the selected/active layer, same as editing. Though in your screenshots the selected layer isn't visible, so maybe the functionality should be disabled.

@hamishcampbell opinions?

rcoup avatar Nov 07 '22 10:11 rcoup

If we can successfully hook into the layer being hidden we could do that, the most odd case is both visible but the one with the select feature on not at the top.

pfw avatar Nov 07 '22 23:11 pfw