FTPS support

[marcandrews]

Please add FTPS support

[marcandrews]

Seems you're using node-ftp, which supports FTPS. You could try node-ftps, which supports FTP, FTPS and SFTP.

[kooohei]

yea I know. I was try that and node-ftp, jsftp. node-ftps should install "lftp" on environment, that is not standalone. i.e just a wrapper. jsftp able to use ftps. if I add to ftps function to synapse. I'll use that.

or...

write myself..

[marcandrews]

Can jsftp do SFTP too? If it can, you should definitely use that. I can help convert some functions in SynapseDomain.js from node-ftp to jsftp.

[kooohei]

could not sftp, jsftp can FTP[S] I was try all of ftp module in npm. jsftp has clitical by synapse. but I forgot.

so what function you want to synapse?

Synapse use node-ftp for FTP and ssh2 for SFTP. if you need FTPS, I would add jsftp for FTPS. however, maybe I think jsftp could not something. that was Symlink related

[marcandrews]

I'd really like FTPS support.

I was really hoping there was a module that would give you all three FTP, SFTP and FTPS, and thus decrease the amount functions required in Synapse Domain.is, but it looks like there isn't one.

[marcandrews]

Wait, node-ftp supports FTPS so it should be easy to add FTPS support without adding or changing to another module.

[marcandrews]

OK, so I just tested FTPS connections with node-ftp. All you have to do is add secure: true to your connect object config and it should work. Ideally, you'd probably want to add some UI to choose between the available options for secure (i.e. true, 'control' or 'implicit').

[marcandrews]

OK so I added FTPS support. Which branch should I fork so that I suggest a pull request?

[kooohei]

I wake now. oh thanks! I will confirm it from now. ok plz fork from master :)

[kooohei]

so FTPS different to FTP is only port number and secure option via node-ftp right?

[marcandrews]

Port number is the same ... so it's just the secure option.

I forked your master and made some changes, but when I tried to load it into Brackets, it failed. So made changes to the version on Brackets > Extensions and it worked. Is your master on GitHub in sync and and uptodate with the version on Extensions?

[kooohei]

sorry plz try again from master sync. yes you should sync master first.

You should diff between current source and yours . then SynapseDomain.js replace your source. UI is ready.

[marcandrews]

Yeah, I don't know what's wrong with your repo. When I download the ZIP of your master, and drag it to Brackets > Extensions, the installation always fails, so I can't test it.

[kooohei]

do you do "npm install" in the node folder?

[marcandrews]

How exactly do I do that? I'm running Brackets on Windows 10.

I can usually just download the ZIP from GitHub and drag it to to Brackets > Extensions and it installs fine, but with your repo, I can't do that. Any ideas?

[kooohei]

Oh realy? I could not. Ok what you see in the brackets-synapse folder?

[marcandrews]

It's exactly the same as your master

[kooohei]

If you can see the "node" directory then make sure is exist node_modules directly into that.

[marcandrews]

It's in your master, so it's in the ZIP I download from GitHub

[kooohei]

Ah I see. First you should fork my master repos by git. And nodejs and npm install your pc. Then execute the npm install inside of the forked dirs

[kooohei]

Would not pull request from download files..

[kooohei]

and Your modified FTPS is included modes all of them?

[marcandrews]

I'm on Windows so I can't easily run npm install. Anyway, it seems like your repo on GitHub is missing crypto-js, font-awesome, homedir, q, and ssh2 from node/node_modules ... probably because I can't run npm install ... but everything else looks the same.

So I'll just update my fork with my changes and hope for the best :-)

[marcandrews]

OK pull request created

[kooohei]

I had a UI, already created.

I create new branche, can you pull request from that? and plz request with the only change. but I could not confirm, where Implict mode?

[marcandrews]

OK I created a pull request for your ftps branch.

I can't really make a pull request with only one change because they are all related to adding FTPS support.

• https://github.com/marcandrews/brackets-synapse/commit/52c44c79dd8cad302a04b052ff069f9ff1d9d612, https://github.com/marcandrews/brackets-synapse/commit/7a64b4e5752ce46595c5f46b6b995a51054fad30 and https://github.com/marcandrews/brackets-synapse/commit/74e3abf1e55274e23a93120e81d0be49f43dd1b7 are the changes I made before I realized that I couldn't test your repo directly in Brackets
• https://github.com/marcandrews/brackets-synapse/commit/46b4b2e1fad9c8f85db7e45da6d88d9ea63cf349 merges the changes you made to your master after I forked it into my forked repo
• https://github.com/marcandrews/brackets-synapse/commit/668bfd1179e0ae7472b6870f102ce4443c807865 are some additional changes to fix issues that came up once I was able to test

[kooohei]

I only minimal functionality I want included. because When something is not enough that is requested anytime soon to me ><

[kooohei]

I already said UI created. confirm your code, now I don't see differences. it is not a complete FTPS is only waring a secure option. how selected ssl and tls? that is automatic?

[marcandrews]

But that is my pull request ... it will merge all my changes with your repo. Your repo already has 46b4b2e so those changes won't be made again obviously ... so what you'll end up with is my changes added to your repo.

I already created the UI and most of the back end in my repo so it'll be hard for me to revert and integrate my backend with your frontend.

Also, you don't need anything else besides secure = true or control or explicit. To my knowledge, you don't have to choose between SSL and TLS for FTPS.

[marcandrews]

Sorry about the white-space changes :-(