vue-konva icon indicating copy to clipboard operation
vue-konva copied to clipboard

Render container as konva container instead of template

Open boboldehampsink opened this issue 3 years ago • 2 comments

Fixes https://github.com/konvajs/vue-konva/issues/123#issuecomment-1011857689

boboldehampsink avatar Jan 27 '22 09:01 boboldehampsink

I am still not sure what exactly this Pull Request is fixing. And I am not sure it is a good idea to use container in render.

lavrton avatar Mar 15 '22 17:03 lavrton

@lavrton it fixes triggering of this line: https://github.com/konvajs/vue-konva/blob/master/src/utils/index.js#L38

It is triggered by these lines: https://github.com/konvajs/vue-konva/blob/master/src/components/KonvaNode.js#L110-L113

which try to render a <template> tag inside the stage, which is not a Konva node and thus forbidden. This PR attempts to use a proper Konva node here: https://konvajs.org/api/Konva.Container.html

boboldehampsink avatar Mar 16 '22 06:03 boboldehampsink