kong-client-ruby icon indicating copy to clipboard operation
kong-client-ruby copied to clipboard

Published 20 hours ago • verified publisher icon kontena

Services and Routes are missing

Open nevalla opened this issue 7 years ago • 6 comments

Instead of Api object there are now Service and Route objects

nevalla avatar Sep 07 '18 12:09 nevalla

Is there any ongoing effort to handle this issue?

If not, I can intent to help.

arthurmde avatar Nov 11 '19 19:11 arthurmde

I have a branch that added those and I use it with Kong 1.1 and 1.4. https://github.com/kontena/kong-client-ruby/compare/master...mtmail:kong1dot1?expand=1

mtmail avatar Nov 11 '19 20:11 mtmail

@mtmail nice

Do you intend to create a PR?

arthurmde avatar Nov 12 '19 13:11 arthurmde

@mtmail very nice! PRs are always welcome.

nevalla avatar Nov 12 '19 14:11 nevalla

PR created now. Not even sure why I didn't do that back in April.

mtmail avatar Nov 12 '19 16:11 mtmail

This has been fixed in #38

@nevalla is there anything missing in the PR to be approved and published?

arthurmde avatar Dec 17 '19 13:12 arthurmde