AAC-Issues icon indicating copy to clipboard operation
AAC-Issues copied to clipboard

Running threshold commands multiple times

Open Slimerblue22 opened this issue 4 years ago • 5 comments

Instead of only running the threshold command once for any given threshold is runs the command multiple times. Sometimes around 20 times and sometimes only twice.

Console logs: https://pastebin.com/y5CNUAsw

Video: https://www.youtube.com/watch?v=x89iBnMwCTY&feature=youtu.be

Core information

Server version: Paper version git-Paper-444 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT) AAC version: 5.0.9 ProtocolLib version: ProtocolLib v4.6.0-SNAPSHOT-b483 Plugin list: Plugins (18): AAC5, AsyncWorldEdit, BKCommonLib, Citizens, ConditionalCommands*, CoreProtect, Denizen, Essentials, JsonMessageMaker*, LightCleaner, LuckPerms, PlaceholderAPI, ProtocolLib, ViaBackwards, ViaVersion, Watson, WorldEdit, WorldGuard

Special environment information

ViaVersion version: ViaVersion 3.2.1 ProtocolSupport version: Not used ViaBackwards version: 3.2.0 BungeeCord plugins: Not used

Client version is 1.15.2, server is 1.16.5 Localhost server so essentially 0 ping

Configuration

https://pastebin.com/X1d5165n image

Slimerblue22 avatar Jan 27 '21 20:01 Slimerblue22

The current behaviour is intended.

AAC 5 has no general violation center anymore. When the analysis runs, it gets current score of each check. It does not save last score where it exected commands and it might be that score went below threshold between analysis runs. Actions are mainly meant to be used in conjunction with aac reset, that way there are no duplicate executions.

It might be a good solution to add a cooldown feature to ConditionalCommands. That way you don't get spammed, and you will also be informed of people who stay over the threshold once in a while.

Janmm14 avatar Jan 28 '21 02:01 Janmm14

It might be a good solution to add a cooldown feature to ConditionalCommands. That way you don't get spammed, and you will also be informed of people who stay over the threshold once in a while.

How could I use a cool down command in Conditional Commands? I can't seem to find one. I see a way to delay a message but nothing to prevent it from spamming the message.

Slimerblue22 avatar Jan 28 '21 02:01 Slimerblue22

@Slimerblue22 That does not exist, it was an idea I just came up with.

Janmm14 avatar Jan 28 '21 05:01 Janmm14

@Slimerblue22 That does not exist, it was an idea I just came up with.

Oh, my bad. I misunderstood.

Slimerblue22 avatar Jan 28 '21 13:01 Slimerblue22

https://github.com/konsolas/ConditionalCommands/pull/15

Janmm14 avatar Feb 10 '21 11:02 Janmm14