dacite icon indicating copy to clipboard operation
dacite copied to clipboard
verified publisher icon konradhalas

Support PEP 604 unions, types.UnionType

Open antonagestam opened this issue 3 years ago • 1 comments

Fixes #180

This is essentially the same fix as this one: https://github.com/ilevkivskyi/typing_inspect/pull/83

antonagestam avatar Jun 07 '22 12:06 antonagestam

Hi @konradhalas, Is this going to be merged for the next version?

Thanks @antonagestam

If only I spent a few minutes to check if that was already fixed before spending the time to fix it myself :( ... https://github.com/konradhalas/dacite/pull/189

idanmiara avatar Jul 24 '22 15:07 idanmiara

Hi @konradhalas, I too stumbled upon this and spent a lot of time trying to fix things. What makes things harder is that if used in concurrent env, this error sometimes cause deadlocks, so it's easy to start searching in the wrong direction Hope you find time to merge this PR :)

anstadnik avatar Oct 07 '22 07:10 anstadnik

I would also love to see a new version of dacite including this fix. dacite is currently keeping us from consistently using shorthand-typehints for optional attrs in dataclasses :-(

ccwienk avatar Oct 21 '22 14:10 ccwienk

Hello, is this pull request still active? Just encountered an issue because of the issue mentioned.

Sclafus avatar Nov 28 '22 09:11 Sclafus

@antonagestam thank you very much for your PR - good job! I'm sorry you had to wait so long.

konradhalas avatar Dec 19 '22 12:12 konradhalas

@konradhalas No worries, thank you for merging this. OSS is free work and I have a lot of respect for the time it takes from people's lives. So, thanks again! 🙏

antonagestam avatar Dec 19 '22 19:12 antonagestam