nifikop icon indicating copy to clipboard operation
nifikop copied to clipboard

Update bootstrap.conf template for 2.0.0-M1

Open juldrixx opened this issue 1 year ago • 2 comments

Q A
Bug fix? no
New feature? no
API breaks? yes
Deprecations? no
Related tickets partial #360
License Apache 2.0

What's in this PR?

Update of the bootstrap.conf template, to match the one in 2.0.0-M1.

Why?

NiFi added new properties especially for Java 21.

Additional context

NiFiKop won't be able to create cluster older than 1.19. In fact, all the version of NiFi using Java 8. Because the new property java.arg.20=--add-opens=java.base/java.net=ALL-UNNAMED causes an error.

Checklist

  • [X] Implementation tested
  • [X] Error handling code meets the guideline
  • [X] Logging code meets the guideline
  • [X] User guide and development docs updated (if needed)
  • [x] Append changelog with changes

juldrixx avatar Jan 11 '24 12:01 juldrixx

Should I update the helm chart?

juldrixx avatar Jan 11 '24 12:01 juldrixx

I think this sort of change ought to warrant a major version update in nifikop (i.e. nifikop v2.0.0). What do you think?

then the guidance can be:

  • Use nifikop 1.x to deploy NiFi 1.x
  • Use nifikop 2.x to deploy NiFi 2.x

mh013370 avatar Jan 11 '24 13:01 mh013370