lastpass-python icon indicating copy to clipboard operation
lastpass-python copied to clipboard

Misc. Fixes for lastpass-python

Open guilt opened this issue 4 years ago • 2 comments

Hi,

This pull request has some changes in it, including some SecureNote parsing code that was borrowed and improved. Update: Moved the lpass CLI to a separate repo (https://github.com/guilt/lastpass-python-cli)

It's to help someone who was looking for how to get some of the notes data in Python. Please adapt this to your convenience.

Thanks to all the authors who had written some of the original code I took this off.

guilt avatar Aug 20 '19 04:08 guilt

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (41af73a) 72.72% compared to head (9a31f9d) 59.79%.

:exclamation: Current head 9a31f9d differs from pull request most recent head 5b683b3. Consider uploading reports for the commit 5b683b3 to get more accurate results

Files Patch % Lines
lastpass/parser.py 42.35% 49 Missing :warning:
lastpass/vault.py 27.50% 29 Missing :warning:
lastpass/account.py 37.50% 15 Missing :warning:
lastpass/fetcher.py 82.35% 12 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #36       +/-   ##
===========================================
- Coverage   72.72%   59.79%   -12.93%     
===========================================
  Files          10        9        -1     
  Lines         385      592      +207     
===========================================
+ Hits          280      354       +74     
- Misses        105      238      +133     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '19 05:08 codecov[bot]

Would love to see these changes, I am trying to replace lastpass cli's implementation. And use this library for a gtk application :-) so would love the possibility to have the same kind of settings to store the database locally and reauth when a specific time is elapsed :-) These changes allow me to create such thing :-)

combro2k avatar Jan 28 '20 13:01 combro2k