filament-import
filament-import copied to clipboard
Fixes column matching on first field
Proposed changes
Currently the first field can never be matched due to array_search returning 0 as the key which is then interpreted as falsish. This is mentioned in the PR that added this feature.
This PR changes the check from !=
to !==
so that the first array key of 0 isn’t interpreted as false.
Types of changes
- [ ] ✨ New feature (non-breaking change which adds functionality)
- [x] 🛠️ Bug fix (non-breaking change which fixes an issue)
- [ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
- [ ] 🧹 Code refactor
- [ ] ✅ Build configuration change
- [ ] 📝 Documentation
- [ ] 🗑️ Chore
Checklist
- [ ] I have read the CONTRIBUTING doc
- [ ] I have signed the CLA
- [x] Lint and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged and published in downstream modules