filament-import icon indicating copy to clipboard operation
filament-import copied to clipboard

Fixes bug where column headings ending with numbers had their numbers removed

Open caleb-kwp opened this issue 1 year ago โ€ข 0 comments

Proposed changes

When an importing a CSV containing a column heading containing a number, for example photo_damage_1, the heading was being mutated to become photo_damage_. Issue was tracked down to be caused by the options collection's ->map('trim').

Types of changes

What types of changes does your code introduce to Filament Import? Put an x in the boxes that apply

  • [ ] โœจ New feature (non-breaking change which adds functionality)
  • [x] ๐Ÿ› ๏ธ Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน Code refactor
  • [ ] โœ… Build configuration change
  • [ ] ๐Ÿ“ Documentation
  • [ ] ๐Ÿ—‘๏ธ Chore

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I have read the CONTRIBUTING doc
  • [ ] I have signed the CLA
  • [ ] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

caleb-kwp avatar Jun 22 '23 01:06 caleb-kwp