gulp-combine-media-queries icon indicating copy to clipboard operation
gulp-combine-media-queries copied to clipboard

Published 20 hours ago • verified publisher icon konitter

Node v4 Buffer does not accept objects

Open techmsi opened this issue 9 years ago • 2 comments

Addresses https://github.com/konitter/gulp-combine-media-queries/issues/19 where this module does not work with node v4.

cssJson is an object, and therefore cannot be turned into a Buffer in v4.

techmsi avatar Oct 02 '15 17:10 techmsi

@konitter If possible, I would like to know when this will be accepted, as I need it for a current project. Thank you.

techmsi avatar Oct 05 '15 14:10 techmsi

@konitter I can confirm that this issue exists for node 4 and that the suggested fix prevents the problem - be good to get the PR into the trunk... the fact that you don't make the buffer on this line doesn't seem important as you go on to set file.contents on line 350 and create a buffer for it there

waynetheisinger avatar Oct 17 '15 08:10 waynetheisinger