gulp-combine-media-queries icon indicating copy to clipboard operation
gulp-combine-media-queries copied to clipboard

doesn't work with last version sass

Open anorudes opened this issue 9 years ago • 8 comments

TypeError: must start with number, buffer, array or string

anorudes avatar Sep 10 '15 11:09 anorudes

Hey,

I was having this problem too after a big update of everything.

Turns out it was my upgrade of node.js

I downloaded the latest node 4.0.0 from 2.3.4. After reverting back it works again

https://nodejs.org/en/download/releases/

windows 10 [bootcamp]

MarkMark avatar Sep 14 '15 07:09 MarkMark

+1

thomasklein avatar Sep 15 '15 08:09 thomasklein

The problem is in gulp-combine-media-queries/index.js line 152. Here is the code:

file.contents = new Buffer(cssJson);

If I comment that line out then it seems to work fine again. The contents of cssJson look like:

 { type: 'stylesheet',
  stylesheet:
   { rules:
      [ [Object],
        [Object],
        [Object],
        [Object]
      ]
   }
 }

brianwozeniak avatar Sep 17 '15 23:09 brianwozeniak

Thanks. Hope the author will do to fix in next commit.

anorudes avatar Sep 18 '15 17:09 anorudes

The author hasn't been active on Github for about a year, so I wouldn't expect fixes any time soon!

okiii avatar Sep 23 '15 23:09 okiii

Can you make a fork with the fix?)

anorudes avatar Oct 16 '15 07:10 anorudes

I forked it https://www.npmjs.com/package/gulp-merge-media-queries

1ven avatar Oct 18 '15 18:10 1ven

Looks like no-one is updating/fixing this issue, I prefer to use: Gulp Merge Media Queries https://www.npmjs.com/package/gulp-merge-media-queries

jimbatamang avatar Dec 15 '15 00:12 jimbatamang