gradle-unused-resources-remover-plugin icon indicating copy to clipboard operation
gradle-unused-resources-remover-plugin copied to clipboard

Request: offer UI for the plugin, just like what we have on the IDE

Open AndroidDeveloperLB opened this issue 3 years ago • 4 comments

Like what we get from this :

image

Come to think of it, what are the advantages of using this plugin over this ?

AndroidDeveloperLB avatar Oct 13 '21 20:10 AndroidDeveloperLB

@AndroidDeveloperLB I've used that option recently and it's a shitshow, it removes several things that are being used. Also be careful, it doesn't run on all modules. Say you have hello.kt open for editing/typing. It will run on the module that contains hello.kt and the modules it depends on.

This plugin needs a bit of polishing but it gave me ridiculously superior result - only 3 false removals, easy to undo by hand (and configure build.gradle.kts to never touch them again). Compared to Android Studio where I got easily more than 50 false removals and is not configurable. Not to mention I think this plugin found way more things that should be removed (600 lines removed over 50 files today), though not certain since it's been a week since I ran the Android Studio command.

fmatosqg avatar Nov 04 '21 07:11 fmatosqg

@fmatosqg I know it sometimes has annoying results. No idea how I can set an exclusion list either (to avoid showing me results that I know that shouldn't be removed). Each time I use this tool, I use it very carefully, checking things that seem like a suspicious false-positive.

Anyway, the request here is to have a nice UI like what we have today. This way there could be a nice competition and a good alternative to what we have today.

Please try to make it have even better UI. For me, for example, I think it could be nice to tell it what to ignore (and show this list too).

AndroidDeveloperLB avatar Nov 04 '21 09:11 AndroidDeveloperLB

Hey,

I never contributed to this plugin though I found it useful and wanted to share my opinion.

In my case a UI is not desirable, since I prefer to run it on command line and see the progress. It takes over 20 minutes in my project.

The documentation shows how to skip certain folders and I believe it also supports reg ex.

On Thu, 4 Nov 2021, 20:52 AndroidDeveloperLB, @.***> wrote:

@fmatosqg https://github.com/fmatosqg I know it sometimes has annoying results. No idea how I can set an exclusion list either (to avoid showing me results that I know that shouldn't be removed). Each time I use this tool, I use it very carefully, checking things that seem like a suspicious false-positive.

Anyway, the request here is to have a nice UI like what we have today. This way there could be a nice competition and a good alternative to what we have today.

Please try to make it have even better UI. For me, for example, I think it could be nice to tell it what to ignore (and show this list too).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/konifar/gradle-unused-resources-remover-plugin/issues/40#issuecomment-960604131, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABI4Y4LE6A2K2XDZSYLLSADUKJJW5ANCNFSM5F6DJ53Q .

fmatosqg avatar Nov 19 '21 11:11 fmatosqg

@fmatosqg The request is not to remove the capability of using it in a command line. It's to add a way to use it via the IDE, easier, just like the rest of the tools that the IDE has to reach them.

AndroidDeveloperLB avatar Nov 19 '21 20:11 AndroidDeveloperLB