arp-scan-rs icon indicating copy to clipboard operation
arp-scan-rs copied to clipboard

Add sudo crate functionality

Open gsuyemoto opened this issue 2 years ago • 3 comments

  • Added sudo crate to Cargo.toml => sudo = "0.6"
  • Modified main.rs to add sudo call at the very beginning of main()
  • Removed call to function that checks for sudo privileges in main()
  • Removed function for checking sudo privileges in utils.rs
  • Removed use::std::env in utils.rs as the sudo function seemed to be the only code needing it

gsuyemoto avatar May 03 '23 23:05 gsuyemoto

Moved escalate. Added a short comment for network configuration line below it to help delineate from different logic.

gsuyemoto avatar May 05 '23 18:05 gsuyemoto

Hi @gsuyemoto 👋 Sorry for the delay - I want to merge your changes in the codebase but it looks like the Git history is not 100% clean (all files seems "changed"). Could you check in the "Files changed" tab what went wrong ?

Saluki avatar Aug 16 '23 11:08 Saluki

Hey Corentin!

Oh man, I haven't messed with this code in a while. I had actually added Rust benchmarking and converted the ieee file to bincode and hashmap (for my own use) for faster scanning (although slower loading). I should have created a separate branch for the benchmarking/bincode/hashmap. I can take a look at the admin rights upgrade to pull it out separately for a simpler merge next week if that's cool.

-Gary

On Wed, Aug 16, 2023 at 4:54 AM Corentin B. @.***> wrote:

Hi @gsuyemoto https://github.com/gsuyemoto 👋 Sorry for the delay - I want to merge your changes in the codebase but it looks like the Git history is not 100% clean (all files seems "changed"). Could you check in the "Files changed" tab what went wrong ?

— Reply to this email directly, view it on GitHub https://github.com/kongbytes/arp-scan-rs/pull/5#issuecomment-1680464675, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5S55YV6J3OPHNSSZM7PILXVSYHTANCNFSM6AAAAAAXVB3HVM . You are receiving this because you were mentioned.Message ID: @.***>

gsuyemoto avatar Aug 17 '23 20:08 gsuyemoto