Godot_Film_Grain_Shader icon indicating copy to clipboard operation
Godot_Film_Grain_Shader copied to clipboard

Update to Godot 3

Open padreputativo opened this issue 3 years ago • 5 comments

Can you update it to Godot 3?

padreputativo avatar Aug 23 '21 14:08 padreputativo

I can look at it, but currently I dont have any spare time...

It should not be hard - there is new ViewportContainer managing size of viewport + there would be some changes in shader (like adding const to, well, const 😄 )

AFAIK nothing groundbreaking.

(btw I am owner of this repo - but I changed my github handler because we start using github at work and I didnt use email in git client, so every public repo i commited into is now linked to some random guy who take my old handler 😩 )

kondelik avatar Aug 30 '21 14:08 kondelik

If you want this shader in Godot 3x see PR #2 (WIP, missing Readme.md and some polishing - but you can just clone branch godot3x and give it a try.

Usage is pretty much the same as was for godot2x.

Have whole game under own Viewport and give material to ViewportContainer + maybe have gui in different layer (so it would not be grained)

kondelik avatar Aug 31 '21 08:08 kondelik

Many thanks!

padreputativo avatar Aug 31 '21 09:08 padreputativo

Please, dont close issues with Pull Request - accepting PR will close linked issues 😉 And because #2 is still Work In Progress (i dont have time for polishing), this issue should remains open 😅

kondelik avatar Sep 06 '21 18:09 kondelik

Ops Sorry!

padreputativo avatar Sep 06 '21 18:09 padreputativo