photon icon indicating copy to clipboard operation
photon copied to clipboard

Add status API

Open ybert opened this issue 2 years ago • 2 comments
trafficstars

This is a draft about the status API feature. Resolves #711 I'm not sure about the Nominatim part of the code for import date, so if you have any idea of improvements feel free to ask.

ybert avatar Nov 19 '23 16:11 ybert

@lonvia Could you review it when you have time ?

ybert avatar Nov 30 '23 14:11 ybert

Apologies, my PRs are now causing conflicts.

With updates working again, the status handler will need to query the database for the current import date now instead of just returning the static date read on startup. The date also needs to be updated in the database after updates are finished.

Would you be interested to adapt the code here? It would be a nice addition to the next release.

lonvia avatar Feb 27 '24 10:02 lonvia

@lonvia I made some changes to adapt the code. What do you think ?

ybert avatar Mar 01 '24 11:03 ybert

Looks good to me. Just one more tiny thing: there is another route to updating at https://github.com/komoot/photon/blob/ee3ceaa55fe19ba5e8450728d62a6fc724986409/src/main/java/de/komoot/photon/App.java#L189

This also needs to use the new update function, so that the date is set.

Once you remove the 'draft' status, I'm happy to merge this.

lonvia avatar Mar 05 '24 08:03 lonvia