validkube icon indicating copy to clipboard operation
validkube copied to clipboard

Github logo at top right not working for validkube.

Open 7h3-3mp7y-m4n opened this issue 1 year ago • 7 comments

While moving the cursor toward the GitHub logo at the top right of the website, the logo should redirect to the desired repo , but is not redirecting itself to the Komodor repository as it should. Screenshot 2023-10-02 at 8 35 00 AM

7h3-3mp7y-m4n avatar Oct 02 '23 03:10 7h3-3mp7y-m4n

It is working when you click the star button which is just beside the GitHub logo. But it should change to get redirected when you click on GitHub logo..

shivaabhishek07 avatar Oct 14 '23 06:10 shivaabhishek07

That's my point. Can I work on this ? @shivaabhishek07

7h3-3mp7y-m4n avatar Oct 14 '23 06:10 7h3-3mp7y-m4n

Yeah, you can go ahead and fix this issue. But currently, Komodor has a lack of maintainers(I think) since their last PR merged in March. Once try contacting @nirsht

shivaabhishek07 avatar Oct 14 '23 07:10 shivaabhishek07

okay @shivaabhishek07 .

7h3-3mp7y-m4n avatar Oct 15 '23 11:10 7h3-3mp7y-m4n

I reached @nirsht and I couldn't get any response . So I'm thinking to raise a pr and left it for review .. what you say @shivaabhishek07 ?

7h3-3mp7y-m4n avatar Oct 19 '23 14:10 7h3-3mp7y-m4n

Yeah @7h3-3mp7y-m4n , it's better to raise a PR. Maintainers will take care of whether including that feature or not..

shivaabhishek07 avatar Oct 20 '23 05:10 shivaabhishek07

@shivaabhishek07 got it .

7h3-3mp7y-m4n avatar Oct 20 '23 06:10 7h3-3mp7y-m4n