validkube icon indicating copy to clipboard operation
validkube copied to clipboard

Published 20 hours ago • verified publisher icon komodorio

Dark and Light Theme Toggle Functionality

Open stevenovak123 opened this issue 2 years ago • 3 comments

stevenovak123 avatar Sep 21 '22 13:09 stevenovak123

I ran the scripts in the frontend to lint and still they have shown up in the changes. Sorry for the difficulty caused.

stevenovak123 avatar Sep 21 '22 13:09 stevenovak123

@stevenovak123 can you explain more in details what is the problem ?

nirsht avatar Sep 22 '22 18:09 nirsht

@stevenovak123 Can you also attach pics to here ?

nirsht avatar Sep 22 '22 18:09 nirsht

@stevenovak123 can you explain more in details what is the problem ?

I use prettier as well but my config has them in ' ' instead of " ". I think it is due to the fact there is not a prettier rules file set in the project. if that config file is made and pushed then it will automatically lint it to a default set.

stevenovak123 avatar Sep 23 '22 16:09 stevenovak123

Added the necessary changes as requested. separated the context logic and corrected the " ". Attaching the images of how the changes look. The theme switching button is located on the Navbar beside the github icon. validkube validkubeLightMode_

stevenovak123 avatar Sep 23 '22 18:09 stevenovak123

Hi @stevenovak123 looks great, just to verify, the default theme is dark ?

I am AFK for few days, after that I will merge it and deploy it 🎉

nirsht avatar Sep 25 '22 15:09 nirsht

Hi @stevenovak123 looks great, just to verify, the default theme is dark ?

I am AFK for few days, after that I will merge it and deploy it 🎉

The default is set depending on the users' browser settings.

stevenovak123 avatar Sep 25 '22 17:09 stevenovak123