helm-dashboard icon indicating copy to clipboard operation
helm-dashboard copied to clipboard

Published 20 hours ago • verified publisher icon komodorio

Enhancement/show chart icon and description

Open harshit-mehtaa opened this issue 2 years ago • 4 comments

Fixes #55

harshit-mehtaa avatar Nov 03 '22 12:11 harshit-mehtaa

@undera Can you please cherry-pick the PR and see the API performance? What I observed is API call happens in the background. So once the home page (installed charts list) loads, it takes a while to populate the icon and description until the API execution completes. Maybe there is a better way to handle that?

harshit-mehtaa avatar Nov 04 '22 03:11 harshit-mehtaa

I checked out the code and I see that current slowness cannot be removed. It's not our backend that runs slow, it is Helm that runs slow.

The future solution to this will be to cache results of some operations we do with Helm.

undera avatar Nov 04 '22 16:11 undera

Please help review

harshit-mehtaa avatar Nov 08 '22 16:11 harshit-mehtaa

It looks good IMO. If you have finished and there's no more questions - I will merge it.

undera avatar Nov 08 '22 18:11 undera

I think you can merge it I will check on comment separately

harshit-mehtaa avatar Nov 09 '22 06:11 harshit-mehtaa

Great! Thank you very much!

undera avatar Nov 09 '22 08:11 undera