helm-dashboard icon indicating copy to clipboard operation
helm-dashboard copied to clipboard

Respect default namespace from kubectl config while installing

Open undera opened this issue 2 years ago • 2 comments

Right now it is hardcoded as "default". We have an optional default namespace coming from context information. We should use that (if present) as namespace when installing new chart. In case there is forced namespace set, use it instead.

undera avatar Oct 28 '22 08:10 undera

I see that this logic already exists

https://github.com/komodorio/helm-dashboard/blob/main/pkg/dashboard/static/actions.js#L132

const ns = $("#upgradeModal .rel-ns").val();
setHashParam("namespace", ns ? ns : "default")

Also, while testing locally I observed that the forced namespace feature is already working image

Could you please add more information?

harshit-mehtaa avatar Nov 08 '22 12:11 harshit-mehtaa

The issue is actually about different thing. When you have a namespace configured for a context in your kubectl config file, this setting should be respected at least in the "Install new chart" dialog.

undera avatar Nov 08 '22 13:11 undera