helm-dashboard icon indicating copy to clipboard operation
helm-dashboard copied to clipboard

Make GH Actions step to validate the tag name matches the plugin.yaml

Open undera opened this issue 3 years ago • 5 comments

To avoid broken releases

undera avatar Oct 24 '22 15:10 undera

hey Andrey Pokhilko this issue is still open ?

ADITYADAS1999 avatar Nov 03 '22 13:11 ADITYADAS1999

Yes, it is still open. It assumes a step in release.yaml that will check that plugin.yaml version matches tag name.

undera avatar Nov 03 '22 17:11 undera

So, The action outputs plugin.yaml version as PACKAGE_VERSION and the tag (without 'refs/tags/') as TAG_NAME 🤔

ADITYADAS1999 avatar Nov 04 '22 04:11 ADITYADAS1999

No, we can't generate plugin.yaml by action. The validation step is a safety valve that just checks that content of a certain field inside plugin.yaml matches github.ref_name

undera avatar Nov 04 '22 17:11 undera

No, we can't generate plugin.yaml by action. The validation step is a safety valve that just checks that content of a certain field inside plugin.yaml matches github.ref_name

okey got this 💁🏻‍♂️

ADITYADAS1999 avatar Nov 05 '22 13:11 ADITYADAS1999