Jose R. Gonzalez
Jose R. Gonzalez
Any particular reason why the Apply operation can't be done at the end of the function instead of in a defer clause?
> This PR is blocked by [redhat-certification/chart-verifier#465](https://github.com/redhat-certification/chart-verifier/issues/465). This should be resolved.
Hey folks, @ShellyKa13, @akalenyu - is there anything else I need to do to have this reviewed and considered for merge?
@alicefr Yes, if a caller is attempting to filter export pods using `kubevirt.io.virt-export-service=myVMName`, that would break. As I read it, it's a limitation of the underling string length truncating logic...
@mhenriks @alicefr @ShellyKa13 PTAL - This should be backwards compatible now, preserving the original design of using the `exportv1.VirtualMachineExport{}.Name` for the label's value if it complies with the max length...
@awels Am I misreading https://github.com/openshift/library-go/blob/master/pkg/build/naming/namer.go#L19-L22 - which would return the "{base}-{suffix}"? Also, wouldn't #13039 be a duplicate of the work here?
@mhenriks, already discussed with @awels - They've let me pull their changes in here. I've left the backwards compatible function in place, but I can swap it out if it's...
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
Not stale
This kind of operation cannot be executed by a user pull request. Please open a case via the Partner Acceleration Desk to discuss.