spring-data-sqlite icon indicating copy to clipboard operation
spring-data-sqlite copied to clipboard

Published 20 hours ago • verified publisher icon komamitsu

Merging into Spring Boot DATA JDBC

Open rudolfschmidt opened this issue 1 year ago • 2 comments

Hey, have not tested your implementation but I tried data jdbc out and noticed that there is a lack of support for sqlite.

Your implementation looks not bad so I wonder why not merging into spring boot data jdbc directly?

rudolfschmidt avatar Apr 13 '24 04:04 rudolfschmidt

@rudolfschmidt Thanks for the suggestion!

Let me share my thoughts. Most of the implementation of this project is a basically integration to inject SQLite specific behavior to Spring Data JDBC. So, I guess those implementation would be removed once the Spring Data JDBC team decides to officially support SQLite. So, I'm not feeling so motivated to ask them to merge this project.

Thanks again for considering it, though.

komamitsu avatar Apr 14 '24 10:04 komamitsu

I agree but why not contributing with a PR then?

Please take a look and share your thoughts: https://github.com/spring-projects/spring-data-relational/pull/1770

rudolfschmidt avatar Apr 14 '24 10:04 rudolfschmidt