ngx-gallery icon indicating copy to clipboard operation
ngx-gallery copied to clipboard

Bad images property falsy check in ngDoCheck when loading images async

Open mattgek opened this issue 5 years ago • 1 comments

fetching images from a server and passing it to the images input property with async pipe causes typeError.

Screen Shot 2020-05-22 at 14 44 06 Screen Shot 2020-05-22 at 14 42 56 Screen Shot 2020-05-22 at 14 45 41

Temporary fix by mapping null to undefined

mattgek avatar May 22 '20 12:05 mattgek

I got around this by putting it in its own component. It wouldn't load the images otherwise (not sure why?) <ngx-gallery [options]="galleryOptions" [images]="(cosplay | async)?.imgGalleryUrls" class="ngx-gallery"></ngx-gallery>

windcloak avatar Jun 19 '20 07:06 windcloak