angular-editor icon indicating copy to clipboard operation
angular-editor copied to clipboard

Issue #258: fix link button

Open NikKropin opened this issue 5 years ago • 7 comments

Link button problem arises from commit afe8176. Couldn't figure out what it does, but service is already provided in root and with this commit is injected separately in each component, so they don't share selected text anymore

NikKropin avatar Aug 08 '20 08:08 NikKropin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.10%. Comparing base (d1f94a6) to head (3a30569). Report is 96 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   22.10%   22.10%           
=======================================
  Files           7        7           
  Lines         484      484           
  Branches      102      102           
=======================================
  Hits          107      107           
- Misses        365      367    +2     
+ Partials       12       10    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 08 '20 08:08 codecov[bot]

Bump on this fix

bachonk avatar Aug 19 '20 03:08 bachonk

Thanks! I will try to check this soon as possible.

kolkov avatar Aug 19 '20 05:08 kolkov

Link button problem arises from commit afe8176. Couldn't figure out what it does, but service is already provided in root and with this commit is injected separately in each component, so they don't share selected text anymore Thanks! But the main problem is for multiple editors on the same page. We need to discover solution with this functionality. @NikKropin

kolkov avatar Aug 19 '20 05:08 kolkov

@kolkov I compiled this fix locally and tested it. It works in Angular 10 and fixes the issues with the Link and Custom Classes button.

Fixes: https://github.com/kolkov/angular-editor/issues/278

alexgurrola avatar Sep 12 '20 00:09 alexgurrola

Thanks. I implemented provide one service instance per one editor component. Is it correct for your opinion?

kolkov avatar Oct 24 '20 22:10 kolkov

@kolkov The latest 1.1.5 release fixes all of my outstanding issues.

alexgurrola avatar Oct 27 '20 02:10 alexgurrola