KKGridView icon indicating copy to clipboard operation
KKGridView copied to clipboard

Bug: checkmark badges don't show

Open ghost opened this issue 12 years ago • 7 comments

I think there is just no art for checkmarks. I tried adding some and for whatever reason I simply couldn't get them to show up. If you look at the photo library app on iOS you can see that when you select photos, they all get a nice little checkmark on them so this feature is a must. :)

ghost avatar Mar 23 '12 04:03 ghost

I'm pretty sure the artwork works, but it needs to be included in the bundle. I never looked closely at the merged code which added the fancy image handling thing, I'll have to look.

kolinkrewinkel avatar Mar 23 '12 04:03 kolinkrewinkel

That was my suspicion as well…

jonsterling avatar Mar 24 '12 01:03 jonsterling

I believe this is fixed in 4e0c7779f0e832a80f73df6f76ed1a2bc3eeefe6 (#122). Can someone confirm?

jonsterling avatar Apr 03 '12 22:04 jonsterling

Oh, fail. The image UIPreferencesWhiteCheck.png isn't even in the bundle.

jonsterling avatar Apr 03 '12 23:04 jonsterling

That was just re-added with the pull-request I just merged, no?

kolinkrewinkel avatar Apr 03 '12 23:04 kolinkrewinkel

Nope: 4e0c7779f0e832a80f73df6f76ed1a2bc3eeefe6

(Related to #108)

jonsterling avatar Apr 03 '12 23:04 jonsterling

I'll re-extract the images when I get a chance then.

kolinkrewinkel avatar Apr 03 '12 23:04 kolinkrewinkel