launcher icon indicating copy to clipboard operation
launcher copied to clipboard

Published 20 hours ago • verified publisher icon kolide

Patch utf8 handling

Open directionless opened this issue 5 years ago • 3 comments

Osquery sometimes mis-encodes utf8 data https://github.com/facebook/osquery/issues/5288

This is a broad attempt to repair log files that exhibit that issue. This runs against the entire log file. Hopefully, there isn’t going to be a case where it misfires.

I'm not sure if this is great. On one hand, it fixes a bug in osquery. On the other hand, it introduces a discrepancy between osquery logs and launcher logs. Feel free to vote with 👍 or 👎. I'm going to let this sit a bit

Fixes: https://github.com/kolide/launcher/issues/445

directionless avatar May 03 '19 17:05 directionless

I'm not confident this will behave correctly, and there's one downvote. So I'm going to close this.

directionless avatar Sep 05 '19 13:09 directionless

Sounds like we probably want to revisit this. Probably only triggering repairs on utf8 errors

directionless avatar Aug 06 '20 19:08 directionless

In light of the additional conversation on #445, let's revisit this.

This is a pretty heavy handed attempt to repair the data, and failing that, redact it,

I don't have much for a test case though.

directionless avatar Jan 21 '21 02:01 directionless

This was fixed upstream, and I haven't seen this occur in ages. So I'm going to close this PR.

directionless avatar Jul 24 '23 12:07 directionless