fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Double logging when Launcher used with Fleet

Open zwass opened this issue 6 years ago • 0 comments

What version of fleet are you using (fleet version --full)?

Any recent version

What operating system are you using?

Any

What did you do?

Enroll a Launcher client with Fleet

What did you expect to see?

One log for every request that the Launcher makes to Fleet.

What did you see instead?

Two (different) logs for each request.

This seems to be because the Launcher service that starts up (https://github.com/kolide/fleet/blob/master/cmd/fleet/serve.go#L206) also takes a logger and logs the same requests before they are passed through to the normal service layer. Maybe the Launcher service should be started without logging middleware (https://github.com/kolide/fleet/blob/master/server/launcher/server.go#L37)?

zwass avatar Mar 13 '19 20:03 zwass