fleet
fleet copied to clipboard
passing osquery configuration to launcher
Moving from code review in #1582
The current implementation of the launcher is somewhat opinionated about osquery config, so when the configuration endpoint was added in https://github.com/kolide/fleet/pull/1544/files#diff-57894187d53a170dbc47ebddb3139466R54 the following change was made:
// Launcher manages plugins so remove them from configuration if they exist.
for _, optionName := range []string{"distributed_plugin", "logger_plugin"} {
if _, ok := config.Options[optionName]; ok {
delete(config.Options, optionName)
}
}
Is it necessary to remove those options? Especially if the user wants to configure multiple logger_plugins
.
// cc @marpaia @zwass
The reason why this is here is because the default configuration options in fleet specify that the tls
logger and distributed plugins should be used. This is problematic for the launcher because obviously the launcher should continue to use the kolide_grpc
plugins, not tls. This was added as a quick fix, but it is obviously not a sustainable solution to this problem.