mindcraft icon indicating copy to clipboard operation
mindcraft copied to clipboard

added the ability to disable translation by setting language to false

Open Lorodn4x opened this issue 1 year ago • 4 comments

Added the ability to disable translation in settings

In this update, I have added a small and simple option to disable translation in the settings.js file. To disable translation, simply set the value to false. I believe this feature will be helpful, as I have encountered issues with incorrect translations. Now users will have the option to turn off translation if it does not meet their expectations.

I hope to see this feature included in the main branch of the repository.

Lorodn4x avatar Oct 28 '24 02:10 Lorodn4x

What exactly is the point of this? When the preferred language is set to English, whatever the LLM says is not translated anyways. Which means it does the same thing as setting the value to false in this PR. Unless I'm missing something?

Vineeth-0 avatar Oct 28 '24 12:10 Vineeth-0

Look how it works now when the default value is "en" then when a player writes a message to the bot then this message is translated into English let's say the player wrote a message in Chinese or Ukrainian then it will be automatically translated into English but the translation is often not very correct and if we turn off the translation at all then the messages will come to the bot in the language in which it was written, and in this case the message will be correct even though it will not be translated

Lorodn4x avatar Oct 28 '24 14:10 Lorodn4x

if you don't need translation, you can turn it off and manually adapt the Bot profile config to your language and it will work well, I've already checked it several times and that's exactly how I use it

Lorodn4x avatar Oct 28 '24 14:10 Lorodn4x

Right I'm aware and I understand all of that but when you talk to a LLM in a different language such as Chinese, it will most likely respond in that language. The reason I made the LLM respond in english, then translated it is so the commands themselves and any code written by the LLM is not in a different language.

Vineeth-0 avatar Oct 29 '24 03:10 Vineeth-0

OH I see what you want. It will translate incoming messages to english, even when set to english. This is just unnecessary, but also means you can't let the language model do the translating for you. I've merged #273, which makes it so when the language is set to "english" it will not google translate at all. I prefer this solution. Thanks!

MaxRobinsonTheGreat avatar Nov 02 '24 16:11 MaxRobinsonTheGreat