Question: Interested in a refactored version?

[karatekaneen]

Thank you for this great repo!

I made a fork a while back and to be able to add the functionality we needed I did a refactor to Typescript.

Major stuff i did:

• Split up into multiple files for better readability
• Converted to Typescript
• Added support for multiple users and buckets.

I realize that some of the changes might be outside of the scope of this project but if you want I can open a PR?

[kolban-google]

Oooh ... let me stew on this a while. I don't speak "typescript" ... I'm just simple JavaScript shaped. Let me read on what the value (generically) is in Typescript and then contemplate whether I want to accept a complete migration to that variant. At a minimum, I'd be more than willing to add a line or two in the README pointing to your repo for a Typescript flavor ... but I'd also add a massive disclaimer that anyone using your code do so as a relationship between you and them and that would have NOTHING to do with Google.

[karatekaneen]

I fully understand. The value of using Typescript, for me at least, is that more errors are caught at the time of writing so I don't have to spend time looking for them. The great support for autocomplete in the editor doesn't hurt either. The split in to multiple files can help future contributions from others since it's (in my opinion) easier to get an overview when each file has a more specified functionality as well as it will be easier to add unit tests.

I also realized that I forgot to mention one of the major changes I did, which was to remove the CLI-part, since we're not going to use it that way but I''m happy to add it back in in the submitted version if requested.

Regarding the disclaimer I think that's a great idea and I'll add that myself to my repo to minimize the risks of any misconceptions about the project's affiliation with Google.

[noahjustinsure]

personally I was able to get this fork up in running in no time and understood what was going on a bit better.