kokorin
Process Listeners V2
Due to the requests of #413 I am kinda forced to make a new PR.
(Can't switch source branches on an existing PR. At least i don't know of a way)
Now a few changes added.
- 1: Written in an actual IDE instead of Code spaces... (Compiles now at least)
- 2: Tests now included and we find out if they work or not. ~~(Never had maven tests run so Github actions help me)~~ Edit: I tested them they are passing on my machine
- 3: Simple default impl provided with the ProcessListener with the Most likely use case being present.
Hope that this is better :)
I have to say, some of these rules you included in code formatting are IMO BS.
Since all these are cosmetic, i picked those that are actually useful changes and made them. If you need to make changes before you merge, then you can do those, but i think the CodeQuality checker is configured way to picky.
Pr is also complete. Any changes that need to be done should be done by you at this point.
If that is not possible, please then close the issue.
@Speiger Why don't you check out my fork: https://github.com/v47-io/jaffree It has different process management you may enjoy.
@vemilyus many reasons, but list a few things.
- My Video Editor tool is already doing everything i need.
- I have my own fork already with all adjustments i need and if i need more i can just do it. This was just me giving back to the original project so i just don't take.
- I am a kotlin avoider i simply don't like to write in kotlin. That is something personal nothing against you but that's a instant no for me.
- I have enough other projects at this point my queue is 6 months delayed and this project has lost its space in the queue already and now that you reminded me that it exists i am considering deleting my repo because stuff like what just happened.
