cherrypick icon indicating copy to clipboard operation
cherrypick copied to clipboard

Relay stopped working; `ReferenceError: targetUri is not defined` error with AP Announce activity into inbox

Open ltlapy opened this issue 6 months ago β€’ 1 comments

πŸ’‘ Summary

AP Inbox 둜 λ“€μ–΄μ˜€λŠ” Announce activityκ°€ ReferenceError: targetUri is not defined 였λ₯˜μ™€ ν•¨κ»˜ μ²˜λ¦¬λ˜μ§€ μ•ŠλŠ” λ¬Έμ œκ°€ λ°œμƒν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€. λ¦΄λ ˆμ΄κ°€ κ²Œμ‹œλ¬Όμ˜ μ „νŒŒμ— announce μ•‘ν‹°λΉ„ν‹°λ₯Ό μ‚¬μš©ν•˜λŠ” 만큼, λ¦΄λ ˆμ΄λ‘œλΆ€ν„° μ˜€λŠ” 연합을 받지 λͺ»ν•˜κ³  inbox 큐가 μŒ“μ΄κ³  μžˆμŠ΅λ‹ˆλ‹€.

πŸ₯° Expected Behavior

Announce activity is accepted without problem

🀬 Actual Behavior

ReferenceError: targetUri is not defined
    at ApInboxService.announceNote (file:///cherrypick/packages/backend/built/core/activitypub/ApInboxService.js:308:74)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ApInboxService.announce (file:///cherrypick/packages/backend/built/core/activitypub/ApInboxService.js:292:36)
    at async ApInboxService.performOneActivity (file:///cherrypick/packages/backend/built/core/activitypub/ApInboxService.js:176:20)
    at async ApInboxService.performActivity (file:///cherrypick/packages/backend/built/core/activitypub/ApInboxService.js:143:22)
    at async InboxProcessorService.process (file:///cherrypick/packages/backend/built/queue/processors/InboxProcessorService.js:187:28)
    at async Worker.processJob (/cherrypick/node_modules/.pnpm/[email protected]/node_modules/bullmq/dist/cjs/classes/worker.js:441:28)
    at async Worker.retryIfFailed (/cherrypick/node_modules/.pnpm/[email protected]/node_modules/bullmq/dist/cjs/classes/worker.js:630:24)

πŸ“ Steps to Reproduce

  • Join some relay and write a post in another server with same relay

πŸ’» Frontend Environment

* Server URL:
  * k.lapy.link (4.9.0)
  * m.keepy.moe (4.9.0)
  * mi.rerac.dev (4.10.0-beta.1)

πŸ›° Backend Environment (for server admin)

<!--
* Installation Method or Hosting Service: docker compose
* CherryPick: 4.9.0
* Node: 
* PostgreSQL:
* Redis: 
* OS and Architecture: Oracle Linux wakaran
-->

Do you want to address this bug yourself?

  • [ ] Yes, I will patch the bug myself and send a pull request

ltlapy avatar Aug 02 '24 12:08 ltlapy