mdspan icon indicating copy to clipboard operation
mdspan copied to clipboard

Port `aligned_accessor` from the Raft fork of Kokkos to mainline.

Open vitor1001 opened this issue 7 months ago • 2 comments

See https://github.com/rapidsai/raft/blob/branch-25.08/cpp/include/raft/thirdparty/mdspan/include/experimental/__p0009_bits/aligned_accessor.hpp.

This implementation was adapted from kokkos/mdspan/blob/stable/examples/aligned_accessor/aligned_accessor.cpp.

Fixes https://github.com/kokkos/mdspan/issues/412.

vitor1001 avatar Jun 18 '25 08:06 vitor1001

Thank you for submitting this. This is still also missing some tests and is_sufficiently_aligned

This was on my TODO list -- if you would like, I can take this over or I can continue to review this.

From my side I prefer you take this over. You know obviously much better this codebase than I do.

vitor1001 avatar Jun 19 '25 07:06 vitor1001

Thank you for submitting this. This is still also missing some tests and is_sufficiently_aligned This was on my TODO list -- if you would like, I can take this over or I can continue to review this.

From my side I prefer you take this over. You know obviously much better this codebase than I do.

Ok I will do, I really appreciate your contribution.

nmm0 avatar Jun 20 '25 07:06 nmm0