kokkos-tutorials icon indicating copy to clipboard operation
kokkos-tutorials copied to clipboard

Add Fortran presentation and exercises

Open Rombur opened this issue 7 months ago • 11 comments

This is the same PR as https://github.com/kokkos/Tutorials/pull/65. I just changed the targeted repository.

Rombur avatar Apr 21 '25 18:04 Rombur

@diehlpk please review

dalg24 avatar Apr 21 '25 20:04 dalg24

@diehlpk please review

I am traveling and will have a look next week.

diehlpk avatar Apr 22 '25 05:04 diehlpk

@diehlpk please review

I am traveling and will have a look next week.

Ping

dalg24 avatar Apr 30 '25 15:04 dalg24

@dalg24 I added some comments. I still need to check the code.

diehlpk avatar Apr 30 '25 15:04 diehlpk

@diehlpk can you check the code too please

Rombur avatar May 13 '25 15:05 Rombur

Also it looks like the new exercises are not "wired in" with the rest of the tutorials.

I don't understand

Rombur avatar May 14 '25 19:05 Rombur

Also it looks like the new exercises are not "wired in" with the rest of the tutorials.

I don't understand

These subdirectories are not added into the parent cmake files

dalg24 avatar May 14 '25 19:05 dalg24

@pzehner I have addressed your comments

Rombur avatar Jun 24 '25 17:06 Rombur

I'm good with the content. However, I'm wondering if the location of the files is appropriate.

For the course, just like Kokkos Kernels, I'd put the files in the Content/Presentations/sections or modularized directory, instead of in a specific Fortran folder. However, I think the current organization of Content/Presentations is very confusing for now.

For the exercises, I discovered there is already a Exercises/fortran-kokkosinterface, containing a PDF course and one saxpy exercice, completely different from this PR and flcl. Should this old exercice remain in the repo? I think it's better to promote only one interface, unless it has advantages compared to flcl.

pzehner avatar Jun 26 '25 08:06 pzehner

I don't have a strong opinion where we put the presentation. I separated it from the other tutorials because I thought it didn't fit our current tutorial program.

@crtrott is the last one to modify the other exercises. Maybe he has an opinion about it?

Rombur avatar Jun 26 '25 13:06 Rombur

I think this should be integrated into the normal tutorial modules. I.e. just add another module instead of a standalone thing. We need to update the general stuff a bit but all in all this should become just another lecture. Regarding exercise directory, I think having a fortran subdirectory is fine. We did move to naming the exercises however instead of just having numbers. Since at some point it becomes somewhat unordered anyway (i.e. the exercises don't strictly build upon each other anymore. Maybe we can do Exercises/Fortran/simple_vector_add and when we have more fortran exercises add a README in the folder with a suggested exercise order?

crtrott avatar Jun 27 '25 15:06 crtrott

@crtrott What about this old exercise Exercises/fortran-kokkosinterface?

pzehner avatar Jun 30 '25 08:06 pzehner

I have integrated the presentation with the other modules. I have also removed the old Fortran exercise.

Rombur avatar Jul 09 '25 17:07 Rombur

@pzehner ping

Rombur avatar Jul 15 '25 13:07 Rombur

done

Rombur avatar Jul 22 '25 14:07 Rombur