kokkos-remote-spaces icon indicating copy to clipboard operation
kokkos-remote-spaces copied to clipboard
verified publisher icon kokkos

Compiler warning is_tiledlayout is deprecated

Open vmiheer opened this issue 1 year ago • 3 comments

I found https://github.com/kokkos/kokkos/pull/6907 but I am not https://github.com/vmiheer/kokkos-remote-spaces/blob/56c3f9c07f2e7a05f76c939cbc2a08ba9b27f267/src/core/Kokkos_RemoteSpaces_DeepCopy.hpp#L580 and the deprecation notice does not specify the alternative.

I stumbled upon it trying to understand KRS + MPI build failure. This warning doesn't cause build failure but there is something in benchmarks/applications is causing it.

vmiheer avatar May 23 '24 02:05 vmiheer

Thanks, yes, I did notice this but was not able to get back to it timely. I should have a fix for this shortly.

janciesko avatar May 28 '24 17:05 janciesko

https://github.com/kokkos/kokkos-remote-spaces/pull/102 should fix those issues.

janciesko avatar May 28 '24 20:05 janciesko

#102 should fix those issues.

Mixing unrelated things into the same PR makes it difficult to audit changes. You should consider dedicate a PR to getting rid of code that was using is_tiledlayout.

dalg24 avatar May 28 '24 21:05 dalg24