kokkos-kernels icon indicating copy to clipboard operation
kokkos-kernels copied to clipboard

Published 20 hours ago • verified publisher icon kokkos

Remove CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS

Open srajama1 opened this issue 4 years ago • 6 comments

@jjwilke : After the ETI files are automatically generated, I don't think we run into this issue of long file names anymore. If yes, can we remove asking users to enable CMAKE_CXX_USE_RESPONSE_FILE_FOR_OBJECTS ?

srajama1 avatar Jul 01 '20 05:07 srajama1

I'm struggling to reproduce this with the old build. I suspect there should be no problems since link lines are now hundreds of times shorter - but am a bit worried about taking it out unless I can reproduce the old issue.

jjwilke avatar Jul 01 '20 20:07 jjwilke

I never reproduced the old issue. It was in windows, mac or ubuntu. There was a PR in Kokkos Kernels to change filenames by an external collaborator to change file names. @ndellingwood : Do you have any thoughts. I am thinking with the shorter file names this option is not needed, but I don't build on windows, mac or ubuntu. The reason for removal is this warned a Trilinos user he needs to set it and that ended up with some weird interaction with Clang. I will post that Trilinos issue link.

srajama1 avatar Jul 01 '20 23:07 srajama1

https://github.com/trilinos/Trilinos/issues/7035

srajama1 avatar Jul 01 '20 23:07 srajama1

Hmm. I guess we can go ahead and remove the warning and see what happens. I'm 99.99% sure we won't ever need response files anymore.

jjwilke avatar Jul 02 '20 02:07 jjwilke

That is what I am thinking too. This was a workaround suggested by Trilinos framework team to avoid having compile errors with long file names (and lots of them).

srajama1 avatar Jul 02 '20 02:07 srajama1

Hi guys,

I'm trying to build Trilinos version 13.2.0 (including Kokkos), and I am indeed running into "Argument list too long" errors, because there are so many "-I" include directories in the compile command. I tried using the CMAKE_CXX_USE_RESPONSE_FILES_FOR_INCLUDES options as it says here:

But it didn't seem to work. I got the same error and still have the long list of "-I" includes in the commands. So I came across this thread as I'm trying to figure out why it didn't work. Was this option removed? Or is it just a warning that was removed?

Thanks, Josh

fontanj avatar May 14 '22 18:05 fontanj