kokkos-kernels icon indicating copy to clipboard operation
kokkos-kernels copied to clipboard

spiluk: Limit memory usage for iw work buffer based on input matrix s…

Open vbrunini opened this issue 3 months ago • 5 comments

…ize.

Observed some application use cases where this buffer was using > 10x the amount of memory needed for the matrix being factorized which lead to OOM's later in the run because insufficient memory was available.

This is one potential solution to #2752 @vqd8a @lucbv

vbrunini avatar Sep 03 '25 18:09 vbrunini

@vbrunini we will also need you to sign off on the commit (git commit --amend -s)

You can also apply the format diff printed out in the failing format check, or apply clang-format 16 yourself.

cwpearson avatar Sep 04 '25 21:09 cwpearson

@vqd8a @cwpearson @lucbv can someone add a new approval for the CI to run? Had to fix some issues in a couple of the builds.

vbrunini avatar Sep 19 '25 12:09 vbrunini

That DCO check keeps biting me :(

vbrunini avatar Sep 19 '25 18:09 vbrunini

Yeah, sorry about that. Becomes a habit eventually...

cwpearson avatar Sep 19 '25 19:09 cwpearson

In ~/.gitconfig you can add to the following:

[format]
        signoff = true

That should automatically apply the signoff for you on all your commits, that's how I handled this. I think you can do the same with git config --global format.signoff true

lucbv avatar Sep 22 '25 13:09 lucbv