Missing parenthesis in coo2crs overload

Open blegouix opened this issue 1 year ago • 2 comments

https://github.com/kokkos/kokkos-kernels/blob/develop/sparse/src/KokkosSparse_coo2crs.hpp#L93C60-L93C69

I think parenthesis are missing on .row, .col and .data. It leads to error: a pointer to a bound function may only be used to call the function

Jul 08 '24 15:07 blegouix

That looks correct indeed, not sure how none of our CI ever complained about this : ( Do you mind opening a PR for that fix?

Jul 08 '24 15:07 lucbv

I can do a PR to fix this particular issue but if the problem is present in other functions something2something and if you want unitary tests to check the implementation, maybe it is better that I am not the one to open the PR.

Jul 08 '24 16:07 blegouix