kokkos
fix: nested namespace holding kk mkl implementation
This PR fixes a compilation error when compiling Trilinos/kokkos-kernels when both mkl and rocsparse are enabled.
Compilation errors look like this:
/Trilinos-sources/packages/kokkos-kernels/sparse/tpls/KokkosSparse_spmv_bsrmatrix_tpl_spec_decl.hpp:35:7: error: no member named 'mode_kk_to_mkl' in namespace 'KokkosSparse::Experimental::Impl::KokkosSparse::Impl'; did you mean '::KokkosSparse::Impl::mode_kk_to_mkl'?
The fix is to add a :: so as to look for KokkosSparse::Impl explicitly in the global namespace.
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.
@maartenarnst sorry for the slow comment here... why not use a non qualified name instead of using this fully qualified one since we are in the same namespace? I think that would look cleaner...
I opened PR #2134 that fixes the issue in a way that I find cleaner, let me know if you have an issues closing this?
@maartenarnst can you see if your issues are resolved with PR #2134 being merged now? I will close this and maybe create an issue instead to track the problem further if there is still a build problem on your end.