kokkos-kernels icon indicating copy to clipboard operation
kokkos-kernels copied to clipboard

`AT:docs-only` label to skip unit tests?

Open cwpearson opened this issue 2 years ago • 4 comments
trafficstars

@e10harvey would it be possible to have a label like: AT: docs-only that only triggers a build of the docs? This would be nice to make it easy for developers to update the documentation? Of course we would still require reviews to catch naughty submitter who try to sneak changes in these PR :p

Originally posted by @lucbv in https://github.com/kokkos/kokkos-kernels/issues/1856#issuecomment-1584802354

Currently, this is handled by marking a PR as AT:WIP to prevent the autotester from running, and then merging it manually anyway.

cwpearson avatar Jun 09 '23 22:06 cwpearson

Unless there is a way to do this via a ini file, I suggest continuing to use AT: WIP. @lucbv: What's the concern with continuing to use AT: WIP for this?

e10harvey avatar Jun 12 '23 13:06 e10harvey

The only concern is I forgot that WIP provides this and that's probably because it's not very explicit, we could create an alias in this case that does the same as WIP. Also if there is a way to mark the PR as passing in that case that would be neat!

lucbv avatar Jun 14 '23 17:06 lucbv

The only concern is I forgot that WIP provides this and that's probably because it's not very explicit, we could create an alias in this case that does the same as WIP. Also if there is a way to mark the PR as passing in that case that would be neat!

@lucbv, @cwpearson: There is a way to do this for all the CI checks managed by GitHub Actions. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks. However, for the Pull Request AutoTester status check, we would need some customization on the GitHub-side. Rather than continuing to use the AutoTester, I would suggest first migrating the AutoTester checks to GitHub Actions. After that, it will be straightforward to implement a docs-only label such that documentation PRs show up as passing.

e10harvey avatar Sep 05 '23 16:09 e10harvey

Okay, thanks for looking into this @e10harvey

lucbv avatar Sep 05 '23 18:09 lucbv