kokkos-kernels icon indicating copy to clipboard operation
kokkos-kernels copied to clipboard

Unrestricted ETI testing does not build

Open jgfouca opened this issue 3 years ago • 3 comments

With kokkos develop commit:

commit 506088b55d4196b31dd81287240feff7051b6e07
Merge: d418fa5 4d06211
Author: Damien L-G <[email protected]>
Date:   Tue Feb 8 10:59:33 2022 -0500

    Merge pull request #4762 from crtrott/rmeove-gcc-toolchain-from-makefile-kokkos
    
    Remove gcc-toolchain auto add for clang in Makefile.kokkos

... configured and installed via:

cmake -DKokkos_ENABLE_OPENMP=ON -DKokkos_ENABLE_SERIAL=ON -DCMAKE_INSTALL_PREFIX=${HOME}/kokkos/install ..

and kokkos_kernels develop commit:

commit 43a039857cbd82ddacd7982c3dd3598ae192bf78
Merge: e6df1db 2e27125
Author: Evan Harvey <[email protected]>
Date:   Tue Feb 8 10:40:31 2022 -0700

    Merge pull request #1300 from e10harvey/issue1250
    
    example/gmres: Switch scalar to bhalf_t

... configured and installed via:

cmake -DKokkosKernels_TEST_ETI_ONLY=OFF -DKokkosKernels_ENABLE_TESTS=ON -DKokkos_ROOT=${HOME}/kokkos/install ..

I get build error:

/ascldap/users/jgfouca/kokkos-kernels/unit_test/blas/Test_Blas1_axpby.hpp: In instantiation of ‘void Test::impl_test_axpby_mv(int, int) [with ViewTypeA = Kokkos::View<float**, Kokkos::LayoutStride, Kokkos::OpenMP>; ViewTypeB = Kokkos::View<float**, Kokkos::LayoutStride, Kokkos::OpenMP>; Device = Kokkos::OpenMP]’:
/ascldap/users/jgfouca/kokkos-kernels/unit_test/blas/Test_Blas1_axpby.hpp:232:67:   required from ‘int test_axpby_mv() [with ScalarA = float; ScalarB = float; Device = Kokkos::OpenMP]’
/ascldap/users/jgfouca/kokkos-kernels/unit_test/blas/Test_Blas1_axpby.hpp:257:46:   required from here
/ascldap/users/jgfouca/kokkos-kernels/unit_test/blas/Test_Blas1_axpby.hpp:143:51: error: no match for call to ‘(Kokkos::View<float** [2], Kokkos::LayoutRight, Kokkos::Device<Kokkos::OpenMP, Kokkos::HostSpace> >) (int&, int&)’
  143 |       EXPECT_NEAR_KK(a * h_x(i, j) + b * h_b_org_y(i, j), h_y(i, j), eps);

...

/home/jgfouca/kokkos/install/include/Kokkos_View.hpp:893:7: error: no type named ‘type’ in ‘struct std::enable_if<false, float&>’
/ascldap/users/jgfouca/kokkos-kernels/unit_test/blas/Test_Blas1_axpby.hpp: In instantiation of ‘void Test::impl_test_axpby_mv(int, int) [with ViewTypeA = Kokkos::View<float**, Kokkos::LayoutStride, Kokkos::OpenMP>; ViewTypeB = Kokkos::View<float**, Kokkos::LayoutStride, Kokkos::OpenMP>; Device = Kokkos::OpenMP]’:

@lucbv , I assigned you since I don't know who to assign.

jgfouca avatar Feb 21 '22 20:02 jgfouca

Discussed with @e10harvey and he saw the same error on his machine.

jgfouca avatar Feb 21 '22 20:02 jgfouca

Okay, I think that would be something good to mention during the stand-up meeting.

lucbv avatar Feb 21 '22 20:02 lucbv

Wow, my very first issue was the leet number!? :)

jgfouca avatar Feb 22 '22 19:02 jgfouca