array_ref icon indicating copy to clipboard operation
array_ref copied to clipboard

P0009 : Address 2017-11 LEWG feedback to advance to LWG

Open hcedwar opened this issue 7 years ago • 6 comments

Address 2017-11 LEWG feedback to advance to LWG.

hcedwar avatar Feb 08 '18 16:02 hcedwar

  • [x] nullptr constructor removed
  • [x] constexpr added to operator()( ... )
  • [x] fixed example typos
  • [x] moved examples to appendix
  • [ ] Changed note in 3.2.2 to a see appendix @hcedwar I changed note to see_below, but not sure if it is in the exact form they want, please review

TODO

@hcedwar small group requested that the oral explanation that you and Christian gave in section 3.5.2 about "layout mapping of indices ... to codomain" be specified in detail

Small group requested ability to index by template arguments, but large group showed no interest, should we mention that in the Appendix?

dsunder avatar Feb 09 '18 17:02 dsunder

@dsunder why did we remove the nullptr constructor again? Don’t we want this to be a nullable type?

dhollman avatar Feb 11 '18 15:02 dhollman

Feedback from LEWG on span and mdspan

From: David Hollman [email protected] Reply-To: kokkos/array_ref [email protected] Date: Sunday, February 11, 2018 at 8:22 AM To: kokkos/array_ref [email protected] Cc: "Edwards, Harold C" [email protected], Mention [email protected] Subject: [EXTERNAL] Re: [kokkos/array_ref] P0009 : Address 2017-11 LEWG feedback to advance to LWG (#48)

@dsunderhttps://github.com/dsunder why did we remove the nullptr constructor again? Don’t we want this to be a nullable type?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/kokkos/array_ref/issues/48#issuecomment-364759371, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHQObYWVcAizcD7VCgAHVWWuZvYmUs8Dks5tTwWngaJpZM4R-qHR.

hcedwar avatar Feb 11 '18 16:02 hcedwar

That was feedback on span, and it was pretty controversial. I don't think span intends to remove the nullptr constructor. I think it was made by someone who wasn't familiar with the importance of a nullptr constructor (their comment was "why not use the default constructor" and there's a really good reason for that: implicit convertibility from nullptr). I went through this in #46

dhollman avatar Feb 12 '18 01:02 dhollman

From LEWG notes (included in #46): Poll to remove nullptr_t constructor: 4-5-3-0-0

hcedwar avatar Feb 12 '18 01:02 hcedwar

I guess I was mixing it up with other discussion; sorry.

dhollman avatar Feb 12 '18 01:02 dhollman